Fix cppcheck warning + small cleanup.

Petr Balek authored 4 years ago and Adam Edward Barton committed 4 years ago

Update ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignData.h, ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignDataBuilder.h, ForwardDetectors/AFP/AFP_DBTools/src/SiGlobAlignDataBuilder.cxx files

This had been partially implemented, but never completed. Will make similar changes
in the 21.X branches (taking care to write out LUCID_SimHitCollection_p1 from 21.0).

    
Don't use references in a range-for if the object must be copised.

Updated ForwardDetectors packages to use FindGeoModel.cmake. Which was introduced
to serve the new GeoModel uni-project, which was introduced into our build with !39900.

Bonus:
 * Turned AFP_GeoModel and ZDC_GeoM into component-only packages
 * Turned ForwardRegionGeoModel into interface + component package

The Boost JSON parser, which is used in a number of places, still
uses <boost/bind.hpp> internally. (Instead of <boost/bind/bind.hpp>.)
To silence the messages about that, I added explicit definitions of the
BOOST_BIND_GLOBAL_PLACEHOLDERS macro in all appropriate places.

Unused private data member.

The `ZdcCablingSvc` (intended as a wrapper to the `ZdcCablingService`
singleton) is not used anywhere in Athena and no component is actually
being built in this package. So delete this code entirely.

ZdcEventTPCnv_15.6.7_test - passes (updated reference file)

Delete the obsolete `Reconstruction/RecExample/RecExCommission` package.
Also delete files in other packages that are related and obsolete. The
`rec.Commissioning` flag remains as that seems to be set to `True` in
various places. Even for those cases, there should be no change in job
configuration.

Move only remaining `MinimalCommissioningSetup.py` to RecExCond package.

Partially addresses ATEAM-677

Remove unused / unneeded ROOT_INCLUDE_DIRS.

ALFA_LocRecLib has compiled code; it's not an interface library.

Nicolas Koehler authored 4 years ago and Walter Lampl committed 4 years ago

Changes to SensitiveDetector unit tests to allow a vector of physical volumes to be used when constructing the G4TouchableHistory instance

Move the `_entries.cxx` file to the `components` sub-directory to follow
ATLAS conventions. Remove unused `SGTests` link dependency.

- remove `atlas_depends_on_subdirs`
- update library and external dependencies
- enable `flake8` where relevant

- remove `atlas_depends_on_subdirs`
- update library and external dependencies
- enable flake8 where relevant

- remove atlas_depend_on_subdirs
- do not install headers not used outside the package
- update link and external dependencies
- enable flake8 where applicable