- Pass large structures by const reference rather than by value.
 - Member initialization.
 

Use preincrement rather than postincrement for user iterators.

Unused variables.

Tile conditions tools have been removed from ToolSvc
because they are not used in standard reconstruction.

JO used in online Tile monitoring have been updated
to use new cabling, to use new geometry, to use new condtitions,
to set up correctly channel timing in the case of laser in the gap,
to fix DQ status in the case of laser run.

Tile conditions have been auto configured for online
the same way as for offline using additional flags.

JO used in online monitoring and reconstrcution of Tile calibration runs
have been udpated to use private tools in Tile TMDB raw channel maker,
to use new geometry, and to configure private tool to calculate OFC on the fly.

Frank Berghaus authored 4 years ago and Walter Lampl committed 4 years ago

The ByteStreamEventStorageInput service provided a legacy job option called FullFileName to specify bytestream input. With the move to EventSelector this option was all but removed from ByteStreamEventInputSvc. The EventSelectorByteStream provieded the input option to specify input. It captured the FullFileName option of the InputSvc. This commit removes the relevant parts of the ByteStreamEventStorageInputSvc and EventSelectorByteStream. It also attempts to move all references in other job options (unless they specify being for an older release).

Configuration of TileCellMaker has been updated to use private tools
and the corresponding JO have been update accordingly.

Unused typedef.

TileRawChannelGetter has been updated to retrieve easy the following
private Tile raw channel builder tools:
- TileRawChannelBuilderFitFilterCool;
- TileRawChannelBuilderMF;
- TileRawChannelBuilderOF1;
- TileRawChannelBuilderWienerFilter.
and to set up correctly DSP container in TileRawChannelBuilderOF1 tool.

JO (jobOptions_TileCalibRec.py) used in reconstruction of Tile calibration runs
has been updated:
- to use correctly private tools mentioned above;
- to add 2020 year (used to find data);
- to ignore DMU errors in Tile Demonstrator;
- to use new conditions tags.

Library dependency fixes.

Frank Berghaus authored 4 years ago and Frank Winklmeier committed 4 years ago

Three things are combined into this commit: style, adoption of recent
C++ components, and some code de-duplication. The style updates
unfortunately makes this look like a full rewrite. Indentation was set
to use two spaces. The range based for loop was adopted where suitable.
Dynamically allocated memory was migrated to be managed using unique_ptr
were possible. The clearing of existing content in the Storegate was
abstrcted into a function.

The RegSelCondAlgs should only be called if the lookup tables they create need updating.
However in serial athena, this mechanism is not implemented and so the conditions algorithms
are unaccountably called for EVERY EVENT.

As such, we need to check whether the lookup table has already been created before actually
continuing with the execute method.

Moved the flake8 check to operate on the python modules and not the
jobOptions of the package, and added a missing StoreGateLib dependency
to the package's component library.

Removed the installation of the package's headers, as they are not needed
anywhere outside of this package.

other files - small clean-up

Removed the usage of atlas_install_python_modules(...), and fixed
the dependencies on both libraries built by the package.

Add missing installed libraries for interfaces and adapt other packages to use
interface libraries.

Library dependency fixes.