Skip to content

Collect slot labels before deciding if they have to be started

Marco Clemencic requested to merge clemenci-v3.0-patches-patch-08304 into v3.0-patches

@cattanem noticed that some slots were started even if they were not expected to (lhcb-2016-patches for example).

I accidentally found that !386 (merged) adds the labels associated to the slot after the configuration was compared with that of the latest build, ending up in finding that all the slots had to be rebuild because of differences like:

2023-07-07 13:24:19,368:DEBUG   : check if to rebuild lhcb-stripping21-firstpass-patches
2023-07-07 13:24:19,372:DEBUG   :   age: 0 (limit 7)
2023-07-07 13:24:19,373:DEBUG   :   changed config:
2023-07-07 13:24:19,373:DEBUG   : *** before
2023-07-07 13:24:19,373:DEBUG   : --- after
2023-07-07 13:24:19,373:DEBUG   : ***************
2023-07-07 13:24:19,373:DEBUG   : *** 115,126 ****
2023-07-07 13:24:19,373:DEBUG   :           "zstd=1.5.2=h3eb15da_6"
2023-07-07 13:24:19,373:DEBUG   :         ],
2023-07-07 13:24:19,373:DEBUG   :         "name": "a65337d0a2384497cadab1b1f3a6f38189196bf26be5ec0b5b0e23d29c5237f8"
2023-07-07 13:24:19,373:DEBUG   : !     },
2023-07-07 13:24:19,373:DEBUG   : !     "labels": [
2023-07-07 13:24:19,373:DEBUG   : !       "all-slots",
2023-07-07 13:24:19,373:DEBUG   : !       "legacy",
2023-07-07 13:24:19,373:DEBUG   : !       "new feature"
2023-07-07 13:24:19,373:DEBUG   : !     ]
2023-07-07 13:24:19,373:DEBUG   :     },
2023-07-07 13:24:19,373:DEBUG   :     "packages": [],
2023-07-07 13:24:19,373:DEBUG   :     "platforms": [
2023-07-07 13:24:19,373:DEBUG   : --- 115,121 ----
2023-07-07 13:24:19,373:DEBUG   :           "zstd=1.5.2=h3eb15da_6"
2023-07-07 13:24:19,373:DEBUG   :         ],
2023-07-07 13:24:19,373:DEBUG   :         "name": "a65337d0a2384497cadab1b1f3a6f38189196bf26be5ec0b5b0e23d29c5237f8"
2023-07-07 13:24:19,373:DEBUG   : !     }
2023-07-07 13:24:19,373:DEBUG   :     },
2023-07-07 13:24:19,373:DEBUG   :     "packages": [],
2023-07-07 13:24:19,373:DEBUG   :     "platforms": [

The labels were then added later making the diff wrong.

/cc @rmatev

Merge request reports