made getpack fail if the project is not hosted on SVN

See LBCORE-1087

LbConfiguration/python/LbConfiguration/Project.py

@@ -152,6 +152,7 @@ class ProjectConf(ProjectBaseConf):
         self._tarballname = "_".join([self.NAME(), self.NAME()])
         self._lcgtarballname = None
         self._hasbinary = True
+        self._inSVN = {}
         self.enableSetenvAlias()
         self.enableSetupAlias()
     def setCMTExtraTags(self, taglist):
@@ -311,7 +312,22 @@ class ProjectConf(ProjectBaseConf):
         """ Access function for the binary nature """
         return self._hasbinary
 
-
+    def inSVN(self, version=None):
+        '''
+        Return True if the main project repository is on SVN.
+        '''
+        if version not in self._inSVN:
+            try:
+                from LbRelease.SoftConfDB.SoftConfDBRO import SoftConfDBRO
+                from urlparse import urlsplit
+                sdb = SoftConfDBRO()
+                uri = urlsplit(sdb.getSourceURI(self.name(), version))
+                self._inSVN[version] = uri.scheme == ''
+            except Exception, x:
+                logging.warning('cannot query software DB for project %s: %s',
+                                self.Name(), x)
+                self._inSVN[version] = True
+        return self._inSVN[version]
 
     def __str__(self):
         """ return string representation for printing """

[Ben Couturier]

Maybe we should have a scheme for SVN hosted at CERN? Not sure we'll ever have to force SVN once we've migrated to GIT...

[Marco Clemencic]

May be and may be not. This inSVN at the moment means more "can I get it with getpack?".

In the long term getpack will disappear and this Project class will be replaced by something else, so I would not worry too much at the moment.

[Ben Couturier]

Fair enough