Make lb-use overwrite the current remote if necessary

This allows you to override the current remote using lb-use, instead of having to do git remote rm

Users will end up doing this if there is a problem when running lb-use, for example when they don't have access to the repo, or they abort the git fetch

LbRelease/scripts/git-lb-use

@@ -14,9 +14,21 @@ fi
 if [ -z "$url" ] ; then
   url=https://:@gitlab.cern.ch:8443/LHCb-SVN-mirrors/$name.git
 fi
+
 echo "calling: git remote add -f '$name' '$url'"
+
+# define a remote "$name", overwrite it if it already exists
+output=$(git remote add "$name" "$url" 2>&1)
+if [ $? -eq 128 ]; then
+    # A remote with that name exists
+    git remote rm "$name"
+    git remote add "$name" "$url"
+    echo "warning: existing remote '$name' overwritten'"
+else
+    >&2 echo -n $output
+fi
+
 set -e
-git remote add "$name" "$url"
 git config "remote.${name}.tagopt" --no-tags
 git config --add "remote.${name}.fetch" "+refs/tags/*:refs/tags/${name}/*"
 git fetch "${name}"

[Marco Clemencic]

Two questions:

• would it not be better to do $? -ne 0?
• what about

  if git remote | grep -q "^${name}\$" ; then
      git remote rm "$name"
  fi
  git remote add "$name" "$url"

  ?

[Igor Babuschkin]

I thought that the 128 return code was specific to this error. Will check up on that. (Catching the exact error would have the benefit of forwarding the other ones). Grepping for the name is probably better as well.