Skip to content

Fix ppg labeling

Emir Muhammad requested to merge emmuhamm_fix_ppg into main

lhcb-simulation/mc-requests!404 (merged) raises an issue where the request was mislabeled with PPG approval required

After investigating, two bugs were found

  1. Wrong indentation of the code, meaning it was erroneously only checking the last eventtype. This doens't affect this request, but should affect requests like lhcb-simulation/mc-requests!296 (merged) with many eventtypes, although this wasn't reported or seen

  2. More importantly, bug in if filetype.endswith("DST"):, as "MDST" does end with "DST". This is fixed now by checking if the last four characters are equal to ".DST", which should provide a stricter condition.

Merge request reports