Skip to content

Add unit tests for LbAPCommon.checks

Giulia Tuci requested to merge gtuci/add_tests into master

Unit tests for LbAPcommon.checks are added (see #7, https://gitlab.cern.ch/lhcb-dpa/project/-/issues/93). This MR relies on the latest version of the LbAPcommon.checks module in !29 (merged)

To do:

  • Add tests for range_check_nd function
  • Fix CI jobs

FYI: @djwhite

The following errors in CI have been now fixed thanks to @cburr

The tests are not executed when pushing because of the pytest.importskip("xrootd") line. However, removing this line, the CI jobs are failing with the error:

ModuleNotFoundError: No module named 'XRootD'
except ImportError:
            raise ImportError(
                """Install XRootD python bindings with:
    
        conda install -c conda-forge xrootd

How can I fix this? Solution: commit 490294cb and f923bbd2

In addition, the CI jobs are also failing with the errors:

tests/checks/test_simple.py:44:166: B950 line too long (165 > 120 characters) 
tests/checks/test_simple.py:57:166: B950 line too long (165 > 120 characters)

In those lines there is the path of a file stored on eos (which is apparently too long). Is there any workaround for this? Solution: commit bd053216

Edited by Giulia Tuci

Merge request reports