Skip to content

Fix sign in eigenmode chi2 in DiagSolvTool

Biljana Mitreska requested to merge bimitres-diagsolv-sign into master
  • When applying constraints they result in negative eigenvalues. Negative eigenvalues are calculates as sign * S(i) and when calculating the chi2 as chi2 = D(i)*D(i)/S(i) the sign was left out so those chi2 values were positive and the correction for lagrange constraints was not applied at all.
  • This affects the convergence flag for the alignment and why we don't see convergence after many iterations

@wouter can you please have a look if this makes sense?

Edited by Biljana Mitreska

Merge request reports