Skip to content

Minor fixes to logic in PV reconstruction

Saverio Mariani requested to merge samarian_fixPV_bugs into master

During commissioning, I noticed the two logic operations in the PV fit:

  • (iter < parameters.maxFitIter || iter < parameters.minFitIter)
  • parameters.zmin >= trk.z && trk.z >= parameters.zmax

were not as intended.

I applied the required fixes in this MR expecting no big changes (see e.g. the enclosed pdf with the normalised comparisons of the reconstructed PV coordinates, obtained with the PV checker), but the pipeline shows the PV reconstruction efficiency has a minor decrease. Opening hence this MR to discuss the minFitIter, mainly with @freiss who worked on this.

While the trk.z condition is fixed, after some discussion with @freiss, the minFitIter requirement is found not to be needed and is removed (see enclosed pdf with outcome of PrimaryVertexChecker scripts)

cc @dovombru

related to #392

Edited by Saverio Mariani

Merge request reports