Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Allen Allen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 183
    • Issues 183
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 73
    • Merge requests 73
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • AllenAllen
  • Merge requests
  • !1116

Fix eta calculation for backward VELO tracks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Saverio Mariani requested to merge samarian_EtaVELOtracks_fix into master Jan 31, 2023
  • Overview 58
  • Commits 11
  • Pipelines 11
  • Changes 20

While commissioning, it was noticed the eta calculation for VELO tracks, based on the momentum, gave nan. With this MR, the state() method on VELO tracks returns a KalmanVeloState instead of a KalmanState (using the conversion already available) and a method for eta calculation based on the slopes is added. Nothing changes for eta calculation of Basic/CompositeParticle.

By monitoring VELO tracks eta on simulation, the obtained distribution is shown below enclosed plot

Also, Velo::Track and Velo::TrackFitParameters structs, unused, are cleaned

Edited Jan 31, 2023 by Saverio Mariani
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: samarian_EtaVELOtracks_fix