Skip to content

Remove scale factors for plume ADC lumi counters and increase size of average ADC counter

Daniel Charles Craik requested to merge dcraik_plumeLumiCounters into 2024-patches

A scale factor (128) was accidentally added to the configuration of the PlumeLumiADC* lumi counters, which reduced the maximum possible value of the counters from 4095 to just under 32. For the average (PlumeAvgLumiADC), this scaling is intentional as it allows us to retain the first two decimal places of the average but the size of the counter was not increased to compensate.

For the average counter, this MR, increases the counter size by 7 bits to recover the previous maximum.

For the other counters, the scale factors are removed to recover the previous maximum.

This MR also fixes a second bug where the first 10 channels of the second FEB were being skipped. This arose as the 10 non-lumi channels from the first FEB are no longer decoded into the same container.

FYI @fferrari @elniel @rsadek

Edited by Daniel Charles Craik

Merge request reports

Loading