Saving counters result as monitoring histogram

Save all counter values with monitoring histograms. This will allow you to easily reach counter values in Monet.

Automatically register unsigned counters and averaging counters via the monitoring hub.

Example of counters output for MC.

For AveragingCounter saving two values in separate bins to histogram: sum of all entries and number of entries.

---

Some values from histogram compared to counter values from logs:

• scifi_consolidate_seeds_matching:n_seed_tracks_sum value = 79787
• scifi_consolidate_seeds_matching:n_seed_tracks_n_enties value = 1000

scifi_consolidate_seeds_matching INFO Number of counters : 1
| Counter | # | sum | mean/eff^* | rms/err^* | min | max |
| "n_seed_tracks" | 1000 | 79787 | 79.787 |

Values stored in float inside Allen and while passing to Gaudi to avoid integer overfilling.

To ensure accurate final value calculations when merging histograms from different machines, the average value is not stored directly for averaging counters.

---

In additional:

• CaloFilterClusters moved to new monitoring system and changed to Averaging counter -> calculate average number per event, instead of global number reconstructed calo clusters per slice (general number of reconstructed calo clusters also stored in histogram).

---

throughput test via testbench:

master: 2025-01-16T09:49:45.012 root INFO Average total throughput: Evts/s = 75294.7

MR: 2025-01-16T09:16:10.010 root INFO Average total throughput: Evts/s = 75294.1

FYI: @adeoyang @jzhuo @dovombru @ahennequ

MONET related MR: https://gitlab.cern.ch/lhcb/Monet/-/merge_requests/108

main/include/AllenMonitoring.h

@@ -26,6 +26,9 @@ namespace Allen::Monitoring {
   template<typename T>
   struct Counter;
 
+  template<typename T>
+  struct AveragingCounter;
+
   struct AccumulatorInfosAndPointers {
     std::size_t offset {0};
     std::size_t size {0};
@@ -98,6 +101,7 @@ namespace Allen::Monitoring {
 
     void registerAccumulator(AccumulatorBase* acc);
     void registerCounter(Counter<unsigned>* c) { m_counters.push_back(c); }
+    void registerAveragingCounter(AveragingCounter<unsigned>* c) { m_av_counters.push_back(c); }
     void initAccumulators(unsigned number_of_streams);
     void mergeAndReset(bool singlethreaded = false);
     char* bufferForStream(unsigned stream_id) const { return m_dev_buffer_ptr[m_stream_current_buffer[stream_id]]; }
@@ -124,6 +128,7 @@ namespace Allen::Monitoring {
 
     std::vector<AccumulatorBase*> m_registered_accumulators;
     std::vector<Counter<unsigned>*> m_counters;
+    std::vector<AveragingCounter<unsigned>*> m_av_counters;
     std::map<std::string, AccumulatorInfosAndPointers> m_accumulators;
   };
 
@@ -251,7 +256,10 @@ namespace Allen::Monitoring {
     using type = T;
     using DeviceType = DeviceAveragingCounter<T>;
 
-    AveragingCounter(const Allen::Algorithm* owner, std::string name) : AccumulatorBase(owner, name) {}
+    AveragingCounter(const Allen::Algorithm* owner, std::string name) : AccumulatorBase(owner, name)
+    {
+      if constexpr (std::is_same<T, unsigned>::value) AccumulatorManager::get()->registerAveragingCounter(this);
+    }
     std::size_t size() const override { return 2; }
     std::size_t elementSize() const override { return sizeof(T); }
     DeviceType data(const Allen::Context& ctx) const { return reinterpret_cast<T*>(currentDevicePtr(ctx.stream_id)); }