Skip to content

Do not enforce a hardcoded ALLEN_PROJECT_ROOT to downstream projects

Marco Clemencicrequested to merge
fix-reloacatability into master

This is a reimplementation of !1938 (merged) that fixes the problem mentioned in !2194 (merged).

It should be noted that ALLEN_PROJECT_ROOT is a special environment variable set by lb-run to implement installation relocation, in particular when setting other environment variables, like PATH, LD_LIBRARY_PATH and PYHTONPATH.

What I'm trying to fix here it that Allen configuration is enforcing a build-time, hardcoded value for it (pointing to a temporary directory), overriding the value lb-run sets, end resulting in hacks like lhcb-datapkg/PRConfig!468 (diffs)

What I have done is to set that variable in build-time environments to point to the source tree of Allen, either when building Allen or a downstream project.

I also modified AllenDependencies.cmake to avoid setting BUILD_TESTING=ON, because that force downstream projects to build tests even if the user decides not to.

Merge request reports