Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Allen Allen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 177
    • Issues 177
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 77
    • Merge requests 77
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • AllenAllen
  • Merge requests
  • !729

Fix issues with ROOTService

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Roel Aaij requested to merge fix_root_issues into master Dec 16, 2021
  • Overview 21
  • Commits 5
  • Pipelines 11
  • Changes 23

@dovombru and I had the some idea as clear from !728 (closed). I went a bit further and refactored the ROOTService to only open ROOT files once and write TTrees once at the end instead of for each batch of events.

In addition, a property has been added to disable the tree writing by default in the KsToPiPi and RICH1Calibration lines. For the stack/production builds ROOT will always enabled and making tuples should not be enabled.

To avoid a crash in the SVMonitor it has been disabled. That monitoring code needs to anyway be migrated to a dedicated monitoring algorithm to properly take into account event masks.

FYI @acasaisv @rilane

Closes #289 (closed)

Edited Jan 12, 2022 by Dorothea Vom Bruch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_root_issues