Skip to content

Unified SciFi decoding

Daniel Campora Perez requested to merge dcampora_unified_scifi_decoding into master

This MR unifies the logic of the SciFi v4 and v6 decoding. It employs a similar mechanism to the cross-version UT decoding: it reads the raw bank version and delegates to a (templated) specialisation of the function.

The following changes were done:

  • Unified the logic of v4 and v6 decoding into three functions: scifi_calculate_cluster_count_t, scifi_pre_decode_t, scifi_raw_bank_decoder_t.
  • Code will throw an exception if a non-supported version is read. Supported versions are currently v4, v5 and v6.
  • Removed any specific v6 configurations. All configurations can now be run on either v4, v5, or v6 data.
  • Adapted tests to use the default configurations.
Edited by Daniel Campora Perez

Merge request reports