Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Allen Allen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 179
    • Issues 179
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 68
    • Merge requests 68
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • AllenAllen
  • Merge requests
  • !783

Fix a bug in two ks line

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Hugo Campora Perez requested to merge dcampora_fix_two_ks_line into master Mar 02, 2022
  • Overview 17
  • Commits 1
  • Pipelines 7
  • Changes 1

It seems that TwoKsLine is giving unstable behaviour in !655 (merged). This MR fixes an outstanding issue in the line which may solve that.

  • Compare all tracks in the vertices (one such comparison was missing).

Separately, a couple of fixes are included:

  • Use float numerals instead of doubles.
  • threadIdx.y was being used - this would have led to a race condition, but luckily parallelism in lines only pan the X dimension. It now uses a sequential iteration instead.
Edited Mar 02, 2022 by Daniel Hugo Campora Perez
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dcampora_fix_two_ks_line