DECLARE_COMPONENT in TupleToolMCPVAssociation

Running TupleToolMCPVAssociation would cause a factory not found error. I added the component, but now get

ToolSvc.LoKi::PV2MC FATAL LoKi::PV2MC:: Exception throw: get():: No valid data at 'Relations/Rec/Track/Default' StatusCode=FAILURE

which is probably related to the data I run on.

Given this tool has probably never been used,can it be removed?

Reported by @cchen2 .

I think so - running lb-glimpse TupleToolMCPVAssociation DaVinci v50r4 finds no use of the tool.

There are probably more cases of defunct classes in our code … ;-).

Well, @erodrigu , tupletools are loaded by user jobs, so one would not expect to find to with glimpse. But the absence if a bug report in years is a sign .

To be clear, what tool are we talking about removing?

That's right, good point :-). I would expect some to appear in Stripping options, though, at least to some extent.

Anyway, I agree that now is the time to be more aggressive and what is not maintained/used won't make it to run 3. This is the only way to converge on a high-quality analysis software suite ...

One can always resurrect things if missed, BTW.

@malexand can correct me if I'm wrong, but this tool was made to study PV association in the context of understanding bunch length studies with extension to analysis. We used it for the note, and were asked by analysts to put it here, hence the reason no one saw it in stripping, etc.

If it needs fixing, this should be fixed, not thrown away?

@adavis the fact nobody made a bug report shows that it was not used for 2 years. We will have to rewrite everything for run 3, so I suggest to do the following

• Mark this as to be removed for Run 3 (there will be a whole batch to remove, so let's do that in a separate MR)
• Fix the bug here and port it to run2-patches.

added bug fix label

added backport run2 label

@masmith I let you do the backporting?

Sure. The diff just shows removing the tutorials though.

/ci-test --merge

Started reference and integration test builds. Once done, check the comparison of build and test results.

unmarked as a Work In Progress

changed the description

• [2020-06-18 17:18] Validation started with lhcb-master-mr#961

@masmith . Hmmm. My git skills are still limited. I should start over again.

mentioned in merge request !638 (merged)

Something went wrong. Trying again with !638 (merged)

closed