Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Analysis Analysis
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCb
  • AnalysisAnalysis
  • Merge requests
  • !817

TOS match on track-by-track basis in MCTupleToolTOS

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ross John Hunter requested to merge rjhunter-TOS-match-by-track into master Sep 22, 2021
  • Overview 27
  • Commits 7
  • Pipelines 6
  • Changes 6

FYI @rmatev @sstahl @mvesteri

Supersedes !807 (closed)

As described in the doc-string of MCTupleToolTOSBase (which matches the trigger candidate to the true MC signal candidate in the event to give a TOS-like efficiency), the matching algorithm we use for TOS efficiencies in HltEfficiencyChecker will break down when it has to handle 3 or 4 track candidates (more specifically it will overestimate). This is expanded upon in the associated vCHEP paper (linked in the doc string). Therefore for HltEfficiencyChecker to give TOS-like efficiencies for any HLT2 line, this envisaged breakdown needs to be fixed.

In this MR I re-write the matching as suggested by the paper: we make sure every track in a candidate matches a track in the MC signal candidate, rather than calculating an average match with all the LHCbIDs of the entire candidate in one container. This should then make the algorithm able to match effectively a candidate of any number of tracks.

With 1 and 2-track lines, I've observed no change in the performance of the algorithm in terms of the TOS efficiencies it gives on B_s \to J/\psi \phi, which is expected.

After !808 (merged), this can now be tested & validated on HLT2 3- and 4-track lines.

TODO:

  • Validate
  • Cleanup

Needed for reliable TOS HLT2 efficiencies in the detector construction paper.

Edited Sep 23, 2021 by Ross John Hunter
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: rjhunter-TOS-match-by-track