Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • B Boole
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCb
  • Boole
  • Merge requests
  • !176

Clean up RichReadout memory management

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christopher Rob Jones requested to merge RichReadout-CleanUpMemoryManagement into master Oct 12, 2018
  • Overview 4
  • Commits 1
  • Changes 16

Addresses a minor memory leak on application exit, found by leak sanitizer.

==2559==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 1 byte(s) in 1 object(s) allocated from:
    #0 0x7f5eb3108898 in operator new(unsigned long) /mnt/build/jenkins/workspace/lcg_contrib_release/LABEL/centos7/build/contrib/gcc-8.1.0/src/gcc/8.1.0/libsanitizer/lsan/lsan_interceptors.cc:229
    #1 0x7f5e8c79733f in Rich::MC::Digi::DetailedFrontEndResponse::initialize() /workspace/build/BOOLE/BOOLE_HEAD/Rich/RichReadout/src/component/RichDetailedFrontEndResponse.cpp:62

Fixing it required overhauling the memory management to use shared and unique pointers as required throughout.

FYI @seaso @bmalecki

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: RichReadout-CleanUpMemoryManagement