2019-05-23 Boole v33r0

This version uses Lbcom v23rX, LHCb v45rX, Gaudi v32r0 and LCG_95 with ROOT 6.16.00, and SQLDDDB v7r*, ParamFiles v8r*, FieldMap v5r*, AppConfig v3r*

This version is released on run2-patches branch and is intended for simulations of Run1 or Run2 data. For Run3, use a version released on master branch

This is the first release on run2-patches branch. It is based on v32r2, with backports from v40r3 of updates relevant to Run1 or Run2 simulation.

New features

• Apply formatting, !215 (@clemenci) [LHCBPS-1838]

• Add copyright statements, !214 (@cattanem)

• Add formatting check in CI jobs, !213 (@clemenci) [LHCBPS-1838]

• RICH - Read photon energy parameters from the DB, Lbcom!355 (@jonrob)

• Updated VeloSim and VeloRadDamage to use new 2nd metal model (optionally) if requested by SIMCOND, Lbcom!353, !204 (@hcroft)

Bug fixes

• Fix issue with LHCbApp().OutputLevel, LHCb!1906 (@cattanem)
  Fixes an issue in which EventLoopMgr is wrongly configured when LHCbApp().OutputLevel is set.

• Protect 32-bit overflow when building rawBank word in CaloFillRawBuffer, LHCb!1901 (@deschamp)

Code modernisations and cleanups

• Decommissioning of COOL, LHCb!1878 (@clemenci) [LHCBPS-1836]

  • Removed unused import of CondDBAccessSvc configurable, !216 (@cattanem)
  • Use dt-* branches instead of CondDB().useLatestTags, !208 (@clemenci)

• Remove support for upgrade, !205 (@cattanem)
  Upgrade not supported on run2-patches branch, use master instead

• fix gcc8 warnings, !212 (@cattanem)

• Fully qualify enums, !211 (@cattanem)

• Remove unused variables, !210 (@cattanem)

• include IRndmGenSvc.h, !209 (@clemenci)

• Adapted to change in logical comparison between StatusCodes, !203 (@cattanem) [LHCBPS-1831]

• Forward compatibility for gaudi/Gaudi!514, !202 (@cattanem) [LHCBPS-1831]

• Removed use of deprecated factories, !201 (@clemenci) [LHCBPS-1830]

• Remove obsolete CVS keywords, !199 (@cattanem)

• Remove packages list from BooleSys/CMakeLists.txt, !181 (@cattanem)
  Packages list was needed for SVN, no longer necessary with Git

Changes to tests

• Fix the reprocessing tests, !206 (@cattanem) [LHCBGAUSS-1008]
  The existing tests were using an Upgrade dataset, no longer supported on run2-patches branch.
  • boole-reprocess-xdst now uses the same XDST file as the Brunel mc11a-xdst test
  • boole-reprocess-xdigi uses a Sim09 xdigi file as described in LHCBGAUSS-1008