Avoid race conditions between tests
Renaming ntuple_file
options some qmtests preventing them from writing on the same file.
In fact this can expose to intermittent issues and file corrumptions.
Solution: moving the ntuple_file
definition from .yaml files (that can be read by multiple qmtests) to .py option files dedicated to each qmtest.
Removing DV options setting if equal to the defaults. Removing also commented bits of codes.
Close #36 (closed)
Merge request reports
Activity
added Configuration DPA-WP3 bug fix labels
assigned to @dfazzini
All seems reasonable from a quick inspection. We have to make it uniform where to set job versus datarelated options (there's been various discussions about this here and there, as you know), but that's a different matter.
(Do not forget to update the copyright years in case that's needed.)
added testing label
- Resolved by Patrick Koppenburg
/ci-test
added ci-test-triggered label
- [2022-03-18 08:07] Validation started with lhcb-master-mr#4014
- [2022-03-23 10:40] Validation started with lhcb-master-mr#4057
Edited by Software for LHCb- Resolved by Patrick Koppenburg
I didn't realise that this MR was different from !675 (merged). Are they orthogonal?
added 7 commits
-
4291b61f...1917e900 - 4 commits from branch
master
- 94328670 - rebase on master and fix conflicts
- b3787268 - Fixed formatting
- 0a313b97 - update copyright
Toggle commit list-
4291b61f...1917e900 - 4 commits from branch
- Resolved by Patrick Koppenburg
/ci-test
mentioned in commit 9b30b739
Stupid question I never dared to ask @rmatev : why do we do Moore throughput tests for DaVinci MRs?
not stupid at all... it is quite wasteful.
I think it goes like this:
- A ci-test of a DaVinci MR will build DaVinci and dependencies and run the DaVinci tests.
- Projects that depend on DaVinci will also be built and tested (to make sure there are no regressions).
- An example of the latter is LHCbIntegrationTests, which also depends on ... Moore.
- Now you need to build Moore as well, but you don't need to run the (nightly) tests.
- The LHCbPR tests are triggered by the build only and do not respect the
no_test
flag for a project. @maszyman is that something we could fix?
Edit: IIUC with the new nightlies, Moore will not be rebuilt in this scenario (as it likely would have already been built, and that build will be reused).
Edited by Rosen Matev
mentioned in commit lhcb-core/LbNightlyTools@3df4c024
mentioned in merge request lhcb-core/LbNightlyTools!380 (merged)