Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • DaVinci DaVinci
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCb
  • DaVinciDaVinci
  • Merge requests
  • !93

Merged
Created Aug 30, 2017 by Michael Thomas Alexander@malexandDeveloper

Fix stripping tests

  • Overview 3
  • Commits 2
  • Changes 12

Fixes all DaVinciTests.fsrs and DaVinciTests.stripping tests. FSR tests have been changed from running S24 to S29. This is a bit slower as S29 has a lot more lines to instantiate. The S22 test has also been changed to run S29, so is also slower. If the speed of S29 is a problem we could change these to run only a subset of the lines.

The S29 test is currently failing due to the issue with the Calo reco being run twice. The resulting FATAL errors are picked up by the test. It also has a ref file, which picks up the differences in the output, but I'm not sure we want this - the stripping output contains several things that won't be identical each time (eg, the address in memory of some algos, and the timing table). So we might want to do away with the ref file, unless these differences can be masked somehow.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 2017-patches-fix-stripping-tests