Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • D Detector
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Detector
  • Merge requests
  • !200

Fix the structure of MuonMaterials.xml

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michal Mazurek requested to merge mimazure-fix-muon-materials into master May 12, 2022
  • Overview 12
  • Commits 1
  • Pipelines 1
  • Changes 1

@edelucia @desimone @bcouturi @sponce @gcorti

This should solve the problem reported by @edelucia when working on the implementation of the Muon system in Gauss(-on-Gaussino). In particular, the geometry defined in compact/trunk/Muon could not have been correctly converted using Geant4Converter in DDG4 resulting in the following error:

Geant4Converter      INFO ++ Convert Volume Copper30micBox                  : 0x4ee8460 TGeoBBox/TGeoVolume assembly:NO
TUnixSystem::Di...  FATAL segmentation violation

The reason it fails is caused by 2 things:

  1. There is something wrong with the format of the MuonMaterials.xml and the properties of the materials could not be correctly converted. I am no expert on this, so I do not really know what is the ideal structure, but I copied the convention used by other sub-detectors. I had to copy some of the missing materials from DDDB as well. Please note, that there are 3 files that define materials: Muon/materials.xml, Muon/fakematerials.xml and Muon/Muon/Materials/MuonMaterials.xml. It might be worth removing those that are not used as it is a little bit confusing. Also, I see that for other sub-detectors we use a prefix, e.g. Muon:Air and not Air. Maybe it would be also good to use this convention.

  2. Geant4Converter was not handling correctly the cases in which the ionization properties of the material are not defined. I applied a patch in our copy of DDG4 used by Gaussino that should result in the following warning:

Geant4Converter      INFO ++ Convert Volume Copper30micBox                  : 0x4bbfcb0 TGeoBBox/TGeoVolume assembly:NO
Geant4Converter   WARNING ++ Created G4 material but ION is not defined and the properites cannot be printed.

More in Gaussino/DD4hep#1.

I am adding lhcb-gaussino to test this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mimazure-fix-muon-materials