Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • D Detector
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 30
    • Issues 30
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Detector
  • Merge requests
  • !314

Add DetectorDataService::initialize(nlohmann::json) and remove other versions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Clemencic requested to merge use-json-for-dds-init into master Nov 08, 2022
  • Overview 9
  • Commits 1
  • Pipelines 4
  • Changes 18

With !254 (merged) I introduced the possibility of initializing DetectorDataService from a YAML object.

With the introduction of JSON as in memory condition format (!286 (merged)) we could use JSON instead of YAML for DetectorDataService initialization too.

There is not performance penalty in using YAML, but JSON is slightly more compact to use.

This MR adds DetectorDataService::initialize(nlohmann::json), removes the other signatures and adapts the tests to use the new method.

Requires LHCb!3851 (merged)

Edited Nov 10, 2022 by Sebastien Ponce
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: use-json-for-dds-init