Skip to content

The maintenance work for the beampipe component.

Menglin Xu requested to merge mexu_beampipe into master

Changes:

  • remove InRich.xml and rename InRich1Debug.xml to InRich.xml then take InRich.xml in Rich1.detector.xml

    It is found one file ending with Debug that InRich1Debug.xml, is loaded in Rich1/detector.xml which looks a bit weird. It is also found that this file is almost the same as InRich1.xml, and InRich1.xml is not used in anywhere. So here I just remove InRich.xml and rename InRich1Debug.xml to Rich1Debug.xml. close #63 (closed) @tlatham @seaso

  • remove a.xml in Pipe directory

    It looks like it is just a copy of compact/components/Pipe/trunk/BeforeVelo-Support.xml and is not used anywhere, so I just delete it

  • refactor Magnet-SupportParams.xml @gcorti

    One ongoing issue with the DD4HEP beampipe is that its supports are not in the correct position, and there are some parts floating in the air, see the plot below. To debug this problem, a careful comparison between DetDesc and DD4HEP is necessary. Unfortunately, the file that places these support positions in DD4HEP, Magnet-SupportParams.xml, is quite disorganized. This file lacks parameter modularization and does not include appropriate comment lines for explanations. I have completely reorganized this file and added comments following DetDesc. Although the wrong place problem still can not be resovled by this merge request, but would be a good start.

    Pipe Magnet Geometry image

Validation:

The changes in this merge request are just some maintenance work for the beampipe and should not affect the geometry. I will trigger a CI test, and check the description in the LHCb PR.

Validated by

  • Core Software
  • RTA
  • Simulation
Edited by Gloria Corti

Merge request reports