Skip to content

Move TVConstants to DeTV and DeTVSensor Member Variables

Restructure the way we access constants for TV.

Rather than

LHCb::Detector::TV::NStations;

you can now use

DeTV.numStations();

This allows flexible and different geometries to be in one compiled stack.

Note: This MR was split into two, with the sensor layout xml rework moved to !855 (merged)

ToDo:

  • Clean-up of xml comments and old junk when ready to merge
  • Add changes to replace TVConstants with info from XML (add new members to DeTV and DeTVSensor)
  • Search for use of static numbers (2 modules per station, 4 sensors per module, etc., and replace with members
  • Prepare corresponding MRs on Rec / LHCb (just Rec?) (again searching for static number usage)
  • Ensure TV Boole MRs pick this change up

cc: @tevans

Rec!4621 (merged) and Allen!2168 (diffs) will need merging into their respective run5 branches upon the merging of this into master.


Validated by

  • Core Software
  • RTA
  • Simulation
Edited by Arthur Marius Hennequin

Merge request reports

Loading