Skip to content

Draft: DO NOT MERGE: Fix to add the assembly attribute, needed after fix for DD4hep 1524

Ben Couturierrequested to merge
fix_assemblies_dd4hep1524 into master

Attempted fix to add the assembly attribute, needed after fix for DD4hep 1524. This is needed for the version of DD4hep with a fix introduced in DD4hep version > 1.33 (commit a9d52c8c5d9c0ce34c7f2c76df2f7b6a0272bc19).

I made it work in this case to validate that there is no more issues, but I do not think we should merge:

  • the DD4hep change is NOT backwards compatible, we would need to change the tags too, in many places
  • adding the assembly attribute does not improve the readability of the geometry, when defined with the volume builder

I think we should ask DD4hep to reintroduce the behaviour of defaulting to an assembly (without the memory leak that triggered this change of course)

Validated by

  • Core Software
  • RTA
  • Simulation

Merge request reports