Skip to content

Fix xml_writer for Detector Refactoring

Emir Muhammad requested to merge dd4hep_future_upgrades_refactor into master

Goes in with Detector!428 (merged)

Fixes xml_writer.py to be compatible with the changes introduced in Detector!428 (merged).

This is essentially done by adding a new compVersion that xml_writer.py can track.

(It should be noted that in the future it would be nice to migrate this towards Detector instead of Gauss :) ).

Things to review:

  • In all_trunk, are we missing any sub-detectors or if we are including ones that aren't needed (eg Gvalve?)
  • Check if these changes work in all use cases. We've only checked using ci-test but not much else
Edited by Emir Muhammad

Merge request reports

Loading