Skip to content
Snippets Groups Projects

Draft: mveltri-inhibit-optical-photons-by-volume

Open Michele Veltri requested to merge mveltri-inhibit-optical-photons-by-volume into master
1 unresolved thread
  • /source/geometry/management/include/G4LogicalVolume.hh
  • /source/geometry/management/include/G4LogicalVolume.icc
  • /source/processes/electromagnetic/xrays/src/G4Cerenkov.cc

This MR provides a new property for the G4LogicalVolume class in order to switch on/off the production of optical photons by volume. See !91

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @kreps, @gcorti, @witoldp, @lsestini, and @dpopov

  • assigned to @veltri

  • @kreps Hi Michal does this MR do the job? In case we could propose this solution to geant4 people and see if it can be of general interest. In case we would avoid duplicating the G4Cerenkov process

  • changed milestone to %Geant4 v10r7p3t3

  • @veltri, this have advantage of being more granular than setting things on the level of material. What I did in my MR has small advantage that is avoids it at the level of physics list, so code actually never goes into G4Cerenkov::PostStepDoIt function, but probably effect is tiny. What is bit of a practical headache is how this will be used in configuration. Issue is that I need to tell every volume which has refractive index defined to turn Cherenkov off if I do not want it. I can do it in hacky way when constructing physics list, but I would need to rather generically go through geometry and get relevant volumes. Better way is to do it from geometry itself inside Detector project, but DD4hep does not know about such property and to get it done is not quick process.

  • On the other hand if we find a clean way to to this at the configuration level, such that recursion is done for you we do not tie each other to a given geometry, being DetDesc or DD4Hep or native Gaussino or a future technology...

    • @kreps My impression is that this approach could be more palatable for G4 people to include the modification permanently in the official code. The volume names could be passed via configuration and than a dedicated tool could get the relevant pointer to the G4logicalVolume and set the property. Of corse such a procedure is best suited for a small number of volumes...how many volumes are involved?

    • But if all volumes share 'something' in their name or/and belong to a mother volume, then we could also programmatically select them.

    • Please register or sign in to reply
Please register or sign in to reply
Loading