Skip to content
Snippets Groups Projects

Use Imported Target for libgit2

Merged Benjamin Morgan requested to merge bmorgan/GitCondDB:pkgconf-imported-targets into master

CMake's pkg-config module does not add -L flags to xxx_LIBRARIES var, and so linking may fail if libgit2 isn't in a path known to the linker.

Use IMPORTED_TARGET argument in pkg_check_modules (available since CMake 3.6) to create a full imported target to libgit2. Update build and config file use to link to imported target.

Merge request reports

Pipeline #690913 failed

Pipeline failed for a0c1de4b on bmorgan:pkgconf-imported-targets

Approval is optional

Merged by Marco ClemencicMarco Clemencic 6 years ago (Mar 12, 2019 11:33am UTC)

Merge details

  • Changes merged into master with d3fa72a8.
  • Deleted the source branch.

Pipeline #749039 passed

Pipeline passed for d3fa72a8 on master

Test coverage 98.80% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading