Modernize CMake configuration, formatting and add copyright checks
As mentioned at the PAC meeting Kepler was never migrated to the new CMake configuration style used in all other projects. This is not a blocker per se, but the old CMake configuration is not maintained anymore and this may cause problems in some cases.
With this MR I introduce
- the new CMake configuration
- code formatting (with the latest incarnation of the checks as in Gaudi)
- missing copyrights (supersede !30 (closed))
Merge request reports
Activity
added lhcb-head label
added 13 commits
- b70f398c - Add format and copyright checking
- 7c3a276e - Remove unneeded files from KeplerSys
- d5b3e7e6 - Initial modernization of top-level CMakeLists.txt
- 0f4fa36b - Tb/TbEvent: modernize config, formatting and copyright
- bed044e7 - Tb/TbKernel: modernize config, formatting and copyright
- adea96b6 - Tb/TbAlgorithms: modernize config, formatting and copyright
- 938271f6 - Tb/TbIO: modernize config, formatting and copyright
- 0394faf1 - Tb/TbAlignment: modernize config, formatting and copyright
- 2e47b2be - Tb/TbAnalysis: modernize config, formatting and copyright
- 7a45921d - Tb/TbGTK: modernize config, formatting and copyright
- 2b72d40c - Tb/TbSimulation: modernize config, formatting and copyright
- 3004bc15 - Tb/TbUT: modernize config, formatting and copyright
- 1e87294e - Tb/Kepler: modernize config, formatting and copyright (and fix Python3 compatibility)
Toggle commit listmentioned in merge request !30 (closed)
assigned to @hschindl
- [2022-09-22 00:19] Validation started with lhcb-head#3377
- [2022-09-23 00:13] Validation started with lhcb-head#3378
- [2022-09-24 00:13] Validation started with lhcb-head#3379
Edited by Software for LHCbFor the record, the build and tests of Kepler in lhcb-head#3377 looks good, so I think this can be merged.
Hi Marco,
This repository is no longer in use (we moved out of LHCb, essentially as this is not strictly an LHCb-only project) - so many of the changes here (i.e. cleanups, modernizing the cmake configuration) already exist there.
We haven't decided what to do with this repository yet - either we will delete (or change to instruction that points to the other repository) or turn it into a mirror for the other repo -
Thanks for the clarification.
We are still building this version of Kepler in LHCb nightly builds, which is the reason why I was asked to make the changes. It would be nice to know where to find the new home of the project and if you are still interested in having it built in LHCb nightly builds.
I just found https://gitlab.cern.ch/TimepixTelescope/Kepler but the readme says to
git clone https://gitlab.cern.ch/lhcb/Kepler.git, which I find very confusing.No problem - and thanks for keeping an eye on this. Indeed - one of the reasons I'm a bit undecided of what to do with this repo is the nightlies. From the point-of-view of the builds, is easy enough to do this in the CI as the project is quite small. For tests is less obvious as they have a significant data dependence (but the tests we have never really used anyway, which is obviously a bad thing, but unless someone has quite considerable time to sort this out, is not going to change any time soon) - Perhaps is best just to remove from the nightlies for now - and if we decide at some point in the future this is the way to go for tests - we can discuss mirroring the repository here and using this infrastructure?
Regarding the readme - this is a mistake I thought we had fixed but apparently not - well spotted and will fix in the next MR.
To test Kepler in LHCb nightlies we do not need a mirror: I can clone from any public repository.
In any case I let you decide what to do with this MR. If you find something useful you can pick it up, or you can let me know if you want me to help adapting it to the new repository.
For the time being I'm removing Kepler from LHCb nightly builds.
mentioned in merge request lhcb-core/LHCbNightlyConf!909 (merged)
removed lhcb-head label