Oddities in detector code, marked PK-R3C
In the lhcb-run3-cleanup campaign, I identified some strange code snippets that need inspection by people more knowledgeable than me. They are marked with PK-R3C in the code. I put them all in a single issue so we keep the overview. The top level issue is https://gitlab.cern.ch/lhcb-dpa/project/-/issues/18
LHCb:
- !2804 (diffs) (PrimaryVertex)
- !2804 (diffs) : was pointing to a location with "Strip" in it.
Rec :
- Rec!2236 (diffs) Not quite sure I understand what is happening here
- Rec!2236 (diffs) : leftSensor is undefined.
- Rec!2236 (diffs) I removed obsolete detectors from this test but did not add the new ones
- Rec!2236 (diffs) To be checked
- Rec!2236 (diffs) pile up code removed, but no replacement
Phys:
- Phys!810 (diffs) : VPDet does not have the required functionality. But maybe this algorithm is obsolete?
- Phys!810 (diffs) : FT cluster doesn't have a clone method. But maybe microDSTTools are no longer needed.
Alignment
Panoramix
- Panoramix!80 (diffs) The expected number of hits needs a revision
- Panoramix!80 (diffs) some FT functionality may be needed here