CaloFutureFillRawBuffer should not update existing RawEvent
@graven started a discussion: (+2 comments)
In general, we should avoid creating and/or updating some existing RawEvent which is shared in the TES, and instead have each algorithm write its own RawBanks into its own RawEvent, and then run a single algorithm which merges all those RawEvents into one. The latter algorithm already exists: RawEventSimpleCombiner. Even better would be if the RawEvent from each individual producer of RawBanks would be written and hidden in the TES, and only a RawBank::View would be published (which is supported already with the 'writeViewFor' trait of Gaudi::Functional) at which point one could use CombineRawBankViewsToRawEvent. And even if not all algorithms would support that, what could be done now already is to use
BackwardsCompatibleMergeViewIntoRawEvent
which could be used to replace the FillRawBuffer here with the combination of FillRawBuffer which does the right thing as described above, and leave the 'dirty' work of updating to BackwardsCompatibleMergeViewIntoRawEvent at which point at least it is clear which algorithm is only there until the rest of the system has caught up.