Remove old backwards compatible digest computation from PropertyConfig
The following discussion from !4050 (merged) should be addressed:
-
@graven started a discussion: do we still need the ability for a
PropertyConfig
to compute its digest?I hope/think not, and if so, we should drop the computation from
PropertyConfig
itself (i.e. removedigest()
) as it uses a 'deviant' text representation (for backwards compatibility) that we should get rid of it (note: and if this is still needed for compatibility with the run1+run2 branch (i.e. to minimize divergence), then the removal could be, if needed, 'backported' to run1+run2 by moving the backwards compatible digest computation to a standalone function in the code that actually relies on the 'deviant' text representation -- i.e. I really think we can and thus should get rid of it here).Note that this should be done in a follow-up MR, and not here - so this comment is intended to be resolved into an issue.