Double / float precision are mixed in manipulating particle and track properties

For electrons which have bremsstrahlung added, the calculated mass of the electron is often no longer the electron mass.

It's strongly suspected that this is a consequence of the mixing of the different precision types in our code: the added 'adl' functions threeMomentum(), slopes() etc. all force a return of float precision, while the internal storage and original precision is in double.

We have to see if we can change these ADL functions to return the proper internal type of the object in question, rather than casting it to another.

added RTA bug labels

fyi @mveghel

indeed, basically everything within https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Event/PhysEvent/include/Event/Particle.h#L440-481 should go from float to double precision

at least there seems support for double precision in the SIMD headers https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Kernel/LHCbMath/include/LHCbMath/SIMDTypes.h#L100

Note that there are some occurrences as well in Track_v1.h related to the slopes.

mentioned in merge request !4988