new parameter in CaloDataType
Add isPhotonXGB
parameter, to be used by CaloHypoEstimator to store result of new photon/pi0 separation classifier.
Merge request reports
Activity
- [2018-05-30 00:03] Validation started with lhcb-g4r103#373
- [2018-05-30 00:03] Validation started with lhcb-gauss-dev#1655
- [2018-05-30 00:07] Validation started with lhcb-moore-test#72
- [2018-05-30 00:08] Validation started with lhcb-2018-patches#228
- [2018-06-02 00:05] Validation started with lhcb-gauss-dev#1658
- [2018-06-02 00:05] Validation started with lhcb-g4r103#378
- [2018-06-02 00:22] Validation started with lhcb-moore-test#75
- [2018-06-02 00:22] Validation started with lhcb-2018-patches#231
Edited by Software for LHCbI made this WIP because:
- You cannot add a new parameter in the middle of an enum, as this will change the value of all the subsequent parameters. Put it at the end
- You have to give an explanation as to why this is needed in 2018-patches branch, which is supposed to be frozen (in principle only bug fixes for software already running in 2018 HLT)
- Resolved by Marco Cattaneo
- Explanation: we try to add new photon/pi0 tool, so we need a new parameter CaloHypoEstimator to store an answer of the new classifier as well as the old one.
- moved to end, added to Name. Where can I find the logic of TypeMask field creation? I searched true example of using TypeMask, but didn't find out a relation between parameter name and TypeMask
Hi Vika, the TypeMask logic is (briefly) explained in the ICaloHypoEstimator interface :
static const int TypeMask[Last] ={ // 0x1 : neutral ; 0x2 : charged ; 0x3 : both
this is just a flag to indicate if the data is relevant for neutral CaloHypo (0x1), charged CaloHypo (0x2) or bot (0x3). This is used in the TupleToolCaloHypo for instance to filter the relevant tuple branch for a given particle, i.e. only neutral&both are associated to gamma and charged&both for electrons. In your case you must use the same mask as for the isPhoton (neutral only 0x1)
Edited by Olivier Deschamps@deschamp, thank you for an explanation
Edited by Viktoriia Chekalinamentioned in commit d8290ce7
mentioned in commit 5f16cdc1
mentioned in merge request !1357 (merged)
mentioned in commit 2e99a244
mentioned in merge request !1358 (merged)
mentioned in merge request Rec!1087 (merged)