Det/CaloDet: run clang-tidy

Gerhard Ravenrequested to merge
clang-tidy-9 into master
  • run clang-tidy -checks=modernize-\*,cppcoreguidelines-\*,clang-analyzer-\*,bugprone-\*
  • move code from DeCalorimeter.icpp into either DeCalorimeter.h or DeCalorimeter.cpp
  • move operator<< out of global scope into class scope when possible
  • change DeSubCalorimeter::side from an int to an enum class
  • prefer const_cast over c-style cast

Merge request reports