Sort and remove duplicate LHCb IDs in Pr::Fitted::Forward::Tracks (!2221) · Merge requests · LHCb / LHCb

Alex Pearce requested to merge apearce-sort-fitted-ids into master Nov 22, 2019
It is a common assumption in other Track classes that vectors of LHCb IDs are sorted and contain unique IDs. However, Pr::Fitted::Forward::Tracks::lhcbIDs doesn't return a sorted container and it can even contain duplicates. Making this part of the Pr::Fitted::Forward::Tracks API eases compatibility when working with other Track types.
Concretely, running HLT1 I see tracks with duplicate IDs:
EventSelector                       SUCCESS Reading Event record 1. Record number within stream 1: 1
EventPersistencySvc                    INFO Added successfully Conversion service:RootCnvSvc
EventPersistencySvc                    INFO Added successfully Conversion service:LHCb::RawDataCnvSvc
HltSelReportsDecoder                WARNING TCK obtained from rawbank seems to be 0 -- blindly ASSUMING that the current HltANNSvc somehow has the same configuration as when the input data was written. Proceed at your own risk, good luck...
HltSelReportsDecoder                WARNING TCK in rawbank seems to be 0 -- blindly ASSUMING that the current HltANNSvc somehow has the same configuration as when the input data was written. Proceed at your own risk, good luck...
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21781724 : type=2 strip=220 sector=23 detRegion=2 layer=1 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 21719287 : type=2 strip=247 sector=90 detRegion=1 layer=1 station=2 } }
EventSelector                       SUCCESS Reading Event record 2. Record number within stream 1: 2
EventSelector                       SUCCESS Reading Event record 3. Record number within stream 1: 3
EventSelector                       SUCCESS Reading Event record 4. Record number within stream 1: 4
EventSelector                       SUCCESS Reading Event record 5. Record number within stream 1: 5
EventSelector                       SUCCESS Reading Event record 6. Record number within stream 1: 6
EventSelector                       SUCCESS Reading Event record 7. Record number within stream 1: 7
EventSelector                       SUCCESS Reading Event record 8. Record number within stream 1: 8
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22287628 : type=2 strip=268 sector=5 detRegion=2 layer=2 station=2 } }
EventSelector                       SUCCESS Reading Event record 9. Record number within stream 1: 9
EventSelector                       SUCCESS Reading Event record 10. Record number within stream 1: 10
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
Duplicate entries: { LHCbID : { UT UTChannelID : 22321326 : type=2 strip=174 sector=38 detRegion=2 layer=2 station=2 } }
EventSelector                       SUCCESS Reading Event record 11. Record number within stream 1: 11
EventSelector                       SUCCESS Reading Event record 12. Record number within stream 1: 12
EventSelector                       SUCCESS Reading Event record 13. Record number within stream 1: 13
EventSelector                       SUCCESS Reading Event record 14. Record number within stream 1: 14
EventSelector                       SUCCESS Reading Event record 15. Record number within stream 1: 15
EventSelector                       SUCCESS Reading Event record 16. Record number within stream 1: 16
EventSelector                       SUCCESS Reading Event record 17. Record number within stream 1: 17
EventSelector                       SUCCESS Reading Event record 18. Record number within stream 1: 18
EventSelector                       SUCCESS Reading Event record 19. Record number within stream 1: 19
EventSelector                       SUCCESS Reading Event record 20. Record number within stream 1: 20
EventSelector                       SUCCESS Reading Event record 21. Record number within stream 1: 21
EventSelector                       SUCCESS Reading Event record 22. Record number within stream 1: 22
EventSelector                       SUCCESS Reading Event record 23. Record number within stream 1: 23
EventSelector                       SUCCESS Reading Event record 24. Record number within stream 1: 24
EventSelector                       SUCCESS Reading Event record 25. Record number within stream 1: 25
EventSelector                       SUCCESS Reading Event record 26. Record number within stream 1: 26
The indicates that something is wrong with the computation of the UT. So, the nicest thing to do would be to fix that problem, but this issue is causing the throughput tests to segfault (as well as my own local tests), so this fix could be considered quickly for merging, and then we can discuss the proper solution.
/cc @chasse @sstahl @ahennequ @olupton
Sort and remove duplicate LHCb IDs in Pr::Fitted::Forward::Tracks

Merge request reports
