Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 46
    • Merge requests 46
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3067

Add some v2 proxies to pr tracks, turn Tag namespace into struct

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christoph Hasse requested to merge chasse_improve_usage_v2_proxies into master May 19, 2021
  • Overview 17
  • Commits 1
  • Pipelines 2
  • Changes 7

MR includes two changes that are aimed at making the usage of the v2::SOACollection-based track containers easier.

  1. turn the definition of the fields from namespace Tag { into struct Tag { and add a traits struct tag_type_t which is aimed to make generic programming easier for these containers.
    E.g. in the track fit where I template over input type I can now get the tag struct via using tag = tag_type_t<InputTracksType>

  2. add some minimal v2::proxies to our the track containers such that I don't even need to know the tag or other details to ask a track how many hits it has etc.

Motivation is pretty much diffs like this: image

Requires changes in Rec!2445 (merged)

fyi: @decianm @peilian @gunther @ahennequ

Edited May 19, 2021 by Christoph Hasse
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: chasse_improve_usage_v2_proxies