Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3078

refactor: removed unsed SOA{Container,Extension}

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christoph Hasse requested to merge chasse_remove_old_soa into master May 27, 2021
  • Overview 7
  • Commits 1
  • Pipelines 2
  • Changes 46

This MR removes the git submodule SOAContainer as well as the additional features implemented in SOAExtension

The reconstruction code had moved to using the SOACollection implemented by @olupton, leaving most of this code unused.

There were a few uses in tests as well as in some algorithms e.g. the PrFilter, but none of this is used by our reconstruction anymore.
Thus, while we still compile it, it isn't used anywhere in the downstream projects.

There is only one file in all the SOAContainer and SOAExtension code that we still need which is the small file SOAExtension/ZipUtils.h which now lives in Event/ZipUtils.h together with SOACollection.

After this MR we should be left with only one SOA implementation which takes away the ambiguity as to what SOA object one should/is using.

There is a few connected small cleanups in Rec! and Moore!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: chasse_remove_old_soa