Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 46
    • Merge requests 46
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3458

Draft: Speed up projectenv.sh by removing duplicates at the source

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Rosen Matev requested to merge rm-lhcb-env-2 into master Mar 14, 2022
  • Overview 32
  • Commits 1
  • Pipelines 16
  • Changes 1

Two changes in separate commits, please review them one at a time to make it clearer.

  • Speed up projectenv.sh generation and execution : moved to !3824 (merged)
    • Improve projectenv.sh generation for super-project builds by populating extra_commands only once (needs cmake 3.19).
    • Use a faster shell-based duplicate removal.
  • Speed up projectenv.sh by removing duplicates at the source. This is more controversial, it might interfere with !3159 (merged), but since I don't really understand it, @clemenci I need your help. In particular, it would be good to note down what is the reason to "override GaudiToolbox internal macro to use lhcb_env".
Edited Oct 20, 2022 by Rosen Matev
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rm-lhcb-env-2