Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 47
    • Merge requests 47
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3489

Draft: Avoid null ptr dereference when CALO param histo file not found

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Christopher Rob Jones requested to merge jonrob/LHCb:avoid-calo-null-ptr-deref-seg-fault into master Mar 30, 2022
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 1

Avoids a seg fault due to a null pointer derefence when the param histo file is not found

Error in <TFile::TFile>: file /usera/jonesc/LHCbCMake/Feature/PARAM/ParamFiles/v8r999/data/CaloPID/DLLs_parametrization_histograms.root does not exist
 *** Break *** segmentation violation

instead the application shuts down more gracefully via an exception

Error in <TFile::TFile>: file /usera/jonesc/LHCbCMake/Feature/PARAM/ParamFiles/v8r999/data/CaloPID/DLLs_parametrization_histograms.root does not exist
CaloChargedPIDsAlg_Long               FATAL  Exception with tag=HistoStore is caught 
CaloChargedPIDsAlg_Long               ERROR HistoStore 	 ParamFile '${PARAMFILESROOT}/data/CaloPID/DLLs_parametrization_histograms.root' not found	 StatusCode=FAILURE
HiveDataBrokerSvc                     FATAL in sysInitialize(): exception with tag=instantiateAndInitializeAlgorithms is caught
HiveDataBrokerSvc                     ERROR instantiateAndInitializeAlgorithms 	 Failed to initialize CaloChargedPIDsAlg/CaloChargedPIDsAlg_Long	 StatusCode=FAILURE
ServiceManager                        ERROR Unable to initialize service "HiveDataBrokerSvc"
HLTControlFlowMgr                     FATAL Error retrieving HiveDataBrokerSvc
ServiceManager                        ERROR Unable to initialize Service: HLTControlFlowMgr
ApplicationMgr                        ERROR Application Manager Terminated with error code 1
Edited Mar 31, 2022 by Christopher Rob Jones
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: avoid-calo-null-ptr-deref-seg-fault