Skip to content

Add the FT v8 decoding

Louis Henry requested to merge lohenry-ft-decoding-v8 into master

v7 is downgraded to "v5 treatment of large clusters", and the previous v7 is upgraded to v8.

Additionally, the following changes are implemented:

  • removed type2 corrupt clusters, they stemmed from a wrong understanding of how v6 should be implemented
  • a bug was found where clusters are not ordered by channel, which caused a crash. We are discussing with the firmware people to know where it could come from;
  • removed the test of links sending more clusters than allowed. It was not taking into account the addition of clusters in size > 8 clusters. Also, it did not do anything in its current implementation.

Test on data using Moore, running seeding:

input_files = glob("/hlt2/objects/LHCb/0000242501/Run_0000242501_HLT20110_20220813-025907-381.mdf")
options.input_files = input_files
options.evt_max = 100000
options.histo_file = 'hlt2_histos.root'

options.simulation = True
options.dddb_tag = 'upgrade/master'
options.conddb_tag = 'upgrade/md_VP_SciFi_macrosurvey'
options.conddb_tag = 'upgrade/forAndre'

Master:

FTRawBankDecoder                       INFO Number of counters : 6
 |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |
 | "Bank containing more clusters than physically possible."|        84 |
 | "Local link larger than physical limit. Bank may be corrupted."|       398 |
 | "Possibly corrupt data (type 1). Ignoring the cluster."|    872881 |
 | "Possibly corrupt data (type 2). Ignoring the cluster."|   2689397 |
 | "Received data from a link that should be disabled. Fix the DB."|       184 |
 | "Totally empty bank."                           |       501 |
PrHybridSeeding                        INFO Number of counters : 21
 |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |
 | "Created T2x1 three-hit combinations in case 0" |    412976 |     201758 |    0.48855 |    0.54073 |       0.0000 |      5.0000 |
 | "Created T2x1 three-hit combinations in case 1" |   2674841 |    1532653 |    0.57299 |    0.57931 |       0.0000 |      10.000 |
 | "Created T2x1 three-hit combinations in case 2" |   4554055 |    2864057 |    0.62890 |    0.67067 |       0.0000 |      21.000 |
 | "Created XZ tracks (part 0)"                    |    300000 |       3797 |   0.012657 |    0.16499 |       0.0000 |      23.000 |
 | "Created XZ tracks (part 1)"                    |    300000 |       9693 |   0.032310 |    0.27098 |       0.0000 |      22.000 |
 | "Created XZ tracks in case 0"                   |    200000 |        738 |  0.0036900 |   0.070259 |       0.0000 |      5.0000 |
 | "Created XZ tracks in case 1"                   |    200000 |       4974 |   0.024870 |    0.22410 |       0.0000 |      23.000 |
 | "Created XZ tracks in case 2"                   |    200000 |       7778 |   0.038890 |    0.30901 |       0.0000 |      22.000 |
 | "Created full hit combinations in case 0"       |      2232 |       2232 |     1.0000 |      0.0000 |      1.0000 |      1.0000 |
 | "Created full hit combinations in case 1"       |      7110 |       7110 |     1.0000 |      0.0000 |      1.0000 |      1.0000 |
 | "Created full hit combinations in case 2"       |     14013 |      14013 |     1.0000 |      0.0000 |      1.0000 |      1.0000 |
 | "Created seed tracks"                           |    200000 |         21 | 0.00010500 |   0.010246 |       0.0000 |      1.0000 |
 | "Created seed tracks (part 0)"                  |    100000 |          3 | 3.0000e-05 |  0.0054771 |       0.0000 |      1.0000 |
 | "Created seed tracks (part 1)"                  |    100000 |         18 | 0.00018000 |   0.013415 |       0.0000 |      1.0000 |
 | "Created seed tracks in case 0"                 |    200000 |          0 |      0.0000 |      0.0000 |       0.0000 |       0.0000 |
 | "Created seed tracks in case 1"                 |    200000 |          1 | 5.0000e-06 |  0.0022361 |       0.0000 |      1.0000 |
 | "Created seed tracks in case 2"                 |    200000 |          5 | 2.5000e-05 |  0.0049999 |       0.0000 |      1.0000 |
 | "Created seed tracks in recovery step"          |    100000 |         16 | 0.00016000 |   0.012648 |       0.0000 |      1.0000 |
 | "Created two-hit combinations in case 0"        |   5408794 |    9806416 |     1.8131 |     2.9362 |       0.0000 |      71.000 |
 | "Created two-hit combinations in case 1"        |   5660599 |2.992837e+07 |     5.2871 |     6.7705 |       0.0000 |      79.000 |
 | "Created two-hit combinations in case 2"        |   5408794 |3.570204e+07 |     6.6007 |     8.5110 |       0.0000 |      108.00 |

Changed:

FTRawBankDecoder                       INFO Number of counters : 6
 |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |
 | "Bank containing more clusters than physically possible."|        84 |
 | "Local link larger than physical limit. Bank may be corrupted."|       398 |
 | "Misordered large cluster"                      |         1 |
 | "Possibly corrupt data (type 1). Ignoring the cluster."|        20 |
 | "Received data from a link that should be disabled. Fix the DB."|       184 |
 | "Totally empty bank."                           |       501 |
PrHybridSeeding                        INFO Number of counters : 21
 |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |
 | "Created T2x1 three-hit combinations in case 0" |    474753 |     234346 |    0.49362 |    0.55523 |       0.0000 |      6.0000 |
 | "Created T2x1 three-hit combinations in case 1" |   2834987 |    1646206 |    0.58067 |    0.60145 |       0.0000 |      10.000 |
 | "Created T2x1 three-hit combinations in case 2" |   5151281 |    3291226 |    0.63891 |    0.70930 |       0.0000 |      20.000 |
 | "Created XZ tracks (part 0)"                    |    300000 |       5114 |   0.017047 |    0.20796 |       0.0000 |      33.000 |
 | "Created XZ tracks (part 1)"                    |    300000 |      10831 |   0.036103 |    0.29837 |       0.0000 |      27.000 |
 | "Created XZ tracks in case 0"                   |    200000 |        843 |  0.0042150 |   0.077313 |       0.0000 |      5.0000 |
 | "Created XZ tracks in case 1"                   |    200000 |       5823 |   0.029115 |    0.25351 |       0.0000 |      33.000 |
 | "Created XZ tracks in case 2"                   |    200000 |       9279 |   0.046395 |    0.35713 |       0.0000 |      32.000 |
 | "Created full hit combinations in case 0"       |      2538 |       2538 |     1.0000 |      0.0000 |      1.0000 |      1.0000 |
 | "Created full hit combinations in case 1"       |      8221 |       8221 |     1.0000 |      0.0000 |      1.0000 |      1.0000 |
 | "Created full hit combinations in case 2"       |     16496 |      16496 |     1.0000 |      0.0000 |      1.0000 |      1.0000 |
 | "Created seed tracks"                           |    200000 |         28 | 0.00014000 |   0.012648 |       0.0000 |      2.0000 |
 | "Created seed tracks (part 0)"                  |    100000 |          4 | 4.0000e-05 |  0.0063244 |       0.0000 |      1.0000 |
 | "Created seed tracks (part 1)"                  |    100000 |         24 | 0.00024000 |   0.016731 |       0.0000 |      2.0000 |
 | "Created seed tracks in case 0"                 |    200000 |          0 |      0.0000 |      0.0000 |       0.0000 |       0.0000 |
 | "Created seed tracks in case 1"                 |    200000 |          1 | 5.0000e-06 |  0.0022361 |       0.0000 |      1.0000 |
 | "Created seed tracks in case 2"                 |    200000 |          4 | 2.0000e-05 |  0.0044721 |       0.0000 |      1.0000 |
 | "Created seed tracks in recovery step"          |    100000 |         24 | 0.00024000 |   0.016731 |       0.0000 |      2.0000 |
 | "Created two-hit combinations in case 0"        |   6013263 |1.125986e+07 |     1.8725 |     3.0703 |       0.0000 |      131.00 |
 | "Created two-hit combinations in case 1"        |   6095014 |3.167405e+07 |     5.1967 |     6.8734 |       0.0000 |      124.00 |
 | "Created two-hit combinations in case 2"        |   6013263 |4.048093e+07 |     6.7319 |     8.6934 |       0.0000 |      138.00 |

Testing clusters:

TestFTClusters                         INFO Number of counters : 2
 |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |
 | "onlyAllen hits"                                |      4498 |
 | "onlyRec hits"                                  |      4498 |
Edited by Louis Henry

Merge request reports