Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 47
    • Merge requests 47
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3907

SOACollection particlev2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arthur Marius Hennequin requested to merge ahennequ_particlev2 into master Dec 16, 2022
  • Overview 154
  • Commits 14
  • Pipelines 28
  • Changes 41

Main features of this set of MR:

  • Replace Vec3 with Vec. This allows to have a uniform interface in reconstruction algorithms and functors, and avoid having too many converters.
  • Replace PrFittedTracks with Tracks_v3. Historically PrFittedTracks was only used in CPU HLT1. Tracks_v3 is the default track model in HLT2, using it allows to merge redundant algorithms and simplify Particle_v2 objects.
  • Remove some converters that are not needed anymore
  • Change all tests that were using FittedTracks to use Tracks_v3. It make more sense to test something that will actually be used.
  • Make ChargedBasics into an SOACollection. Before it was a zip, which cannot be persisted nor referenced into by an other SOACollection.
  • Add NeutralBasics SOACollection.
  • Switch to TCmalloc for HLT1 throughput test. It is now more performant with it and allows simpler integration of SOACollections, without worrying about costly memory allocations.

Goes with Rec!3247 (merged) Moore!1984 (merged) Analysis!942 (merged) lhcb-datapkg/PRConfig!289 (merged)

Edited Mar 03, 2023 by Arthur Marius Hennequin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ahennequ_particlev2