Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3912

More const-correct Linked{From,To}

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gerhard Raven requested to merge more-const-correct-linkedtofrom into master Dec 21, 2022
  • Overview 36
  • Commits 3
  • Pipelines 11
  • Changes 24
  • remove Linked{From,To} constructor which requires an IDataProviderSvc and which fetches (implicitly!) an LHCb::LinksByKey from the TES. Instead, require the caller to provide the LinksByKey explicitly. As a result, Linked{To,From} can now be seen solely as templated extensions of LinksByKey which provide appropriately typed ranges of linked objects. This is a necessary (but not sufficient) step in order to get code which uses MC association to explicitly state their data flow dependencies (which will enable future simplifications to the read-back configuration). In addition, remove the need to specify the 2nd (and 3rd) template arguments to Linked{From,To} and instead make sure the compiler can and will deduce them implicitly.
  • add const where appropriate
  • change return type of Linked{From,To}::range from a vector to a (lazy) range
  • adapt code using Linked{From,To}, including several interfaces which are now more const-correct.

requires Lbcom!647 (merged), Boole!441 (merged), Rec!3254 (merged), Analysis!941 (merged), MooreAnalysis!101 (merged) and Alignment!339 (merged)

Edited Jan 02, 2023 by Gerhard Raven
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: more-const-correct-linkedtofrom