Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3917

Unify various Linker wrapper classes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gerhard Raven requested to merge more-const-correct-linkedtofrom into master Jan 06, 2023
  • Overview 74
  • Commits 1
  • Pipelines 31
  • Changes 17
  • add functionality to LHCb::LinksByKey (link, typed constructor), make it impossible to change sourceID, targetID, ordering after construction (as that would leave any already present data in a bad shape)
  • drop the no longer relevant OutputLinks class
  • drop the unused AllLinks header
  • drop the no longer relevant LinkedFromKey class
  • strip down the LinkerWithKey class to a single static create function for easy migration
  • move LinkerEntry and LinkerRange into LinkerTable as they are implementation details of iterating over the table
  • add warning counter which keeps track of how often Object2MCLinker invokes an algorithm to build a linker table
  • unify 'range' function names, make the inverse range in Object2MCLinker lazy
  • reduce code in LinkerTool using the new functionality in LinksByKey
  • reduce code in LinkerWithKey using the new functionality in LinksByKey
  • remove confusing (and buggy?) Object2MCLinker::linkerTable method

must be merged together with Lbcom!648 (merged) Boole!443 (merged) Rec!3263 (merged) Analysis!943 (merged) MooreAnalysis!102 (merged) Alignment!340 (merged)

Edited Jan 13, 2023 by Gerhard Raven
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: more-const-correct-linkedtofrom