Skip to content

Make sure Git resources are released before git_libgit2_shutdown

Marco Clemencic requested to merge fix-git-entity-resolver-segfault into master

It may happen (in some error condition) that finalize() is skipped, in which case the Git resources might not be released before ~GitEntityResolver, so it's important to ensure they are released to avoid a segfault.

The problem was exposed by gaudi/Gaudi!1432 (merged) because it changed the failure mode of a couple of tests in XMLSummaryKernel (see !4023 (merged)) and the new failure mode hit the corner case I'm fixing here.

/cc @sponce

Merge request reports