Skip to content

Draft: Add test to check that we fail when condition version is missing

Rosen Matev requested to merge rm-invalid-cond into master

~~I noticed that jobs don't fail when the conditions version is a nonexistent tag/branch. This is quite bad. I'm not even sure what conditions are used in this case. ~~

Correction: I gave a nonexistent tag/branch but at the same time I had ConditionsLocation = 'file://... which means the ConditionsVersion value is irrelevant. However, the INFO printout still suggests it is used, which is very misleading. On top of this, as far as I can see, there is no printout of the value of ConditionsVersion.

I would suggest that we abort in case ConditionsVersion is specified when ConditionsLocation = 'file://....

OTOH, when we have ConditionsLocation = 'git://... and supply an nonexistent tag, the job fails but it does so very late. We need an early failure with a clear message.

Here I add a draft of a test for the expected behaviour.

Note that there were recent changes in Detector!422 (merged) which might have affected behaviour.

@sponce @bcouturi @clemenci

Edited by Rosen Matev

Merge request reports