Skip to content

fix of UTNZSWord

Wojciech Krupa requested to merge ut/nzs_fix into ut/master

There was an issue with the NZS decoder recently spotted by me & Mark Tobin. The NZS ADC is encoded in 6b (two's complements method, 6th MSB indicate the sign of integer). Previously we were decoding all 8 bits together since MSBs were 0 as it supposed to be. However, recently we observed strange behavior for disabled channels. The MSB which is supposed to be 0 from time to time becomes 1. So effectively, ADC=0 became ADC=64 (out-of-range UT DAC which operates in the range -32-31). It can be seen on the top plot, which presents overflow values. The proposed fix, forced to decode only 6 MSB instead of 8. This fix was tested as the bottom plot presents plots without overflowing values. The fix consist only NZS decoder which is only on ut/master.

The target of this MR is only ut/master

1

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/34879390

added csv file by Christos in order to make his code work for Errors

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/34883391

Edited by Wojciech Krupa

Merge request reports