Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 198
    • Issues 198
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 46
    • Merge requests 46
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !847

Modernize MuonDAQ

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gerhard Raven requested to merge modernize-muondaq into master Aug 18, 2017
  • Overview 10
  • Commits 1
  • Pipelines 0
  • Changes 15
  • remove private methods from IMuonRawBuffer interface (as they cannot be called through the interface anyway!)
  • add some const in IMuonRawBuffer interface
  • prefer std::array over C-style arrays (to avoid decay into pointers, which loose the information on the size of the array)
  • prefer zero initialization of array over .fill(0)
  • make operator<< friend, in class scope, instead of in global scope
  • make static constants constexpr
  • prefer inherited constructors
  • prefer switch/case over if-then
  • prefer range-based loops
  • prefer Gaudi::Property with direct member initialization over declareProperty
  • reduce scope of variables as much as possible: only declare variables at the point they can be assigned a value
  • prefer .fill(0) for arrays over explicit loops
  • use lambda to consolidate repeated code
  • simplify a few arithmetic expressions
  • prefer STL algorithms over raw loops
  • use a scoped guard over explicitly grouped 'set/reset' calls
  • prefer std::bitset over arrays of bool
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: modernize-muondaq